WIP: fix 281, warn if expiration subpacket is not hashed #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kristelfung ! thanks for your PR. It appears that the appveyor build is failing with something that appears unrelated to this PR, so I'll go on and review it. |
SantiagoTorres
requested changes
Jun 14, 2019
There was a problem hiding this comment.
It mostly LGTM, modulo two nits 👍
However, I wonder if @lukpueh is on board with the way we are solving this issue
lukpueh
requested changes
Jun 18, 2019
There was a problem hiding this comment.
Thanks for you PR, @kristelfung! This is solid work. Please address my comments and we can merge.
lukpueh
reviewed
Jun 19, 2019
lukpueh
reviewed
Jun 19, 2019
lukpueh
approved these changes
Jun 19, 2019
kristelfung
force-pushed
the
fix-281
branch
2 times, most recently
from
f82cdd6
to
70d04dd
Compare
Signed-off-by: Kristel Fung <kristelfung@gmail.com>
|
thanks @kristelfung ! |
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this pull request
Aug 9, 2019
- Updates gpg tests to cover missing lines in gpg-subpackage. - One feature, a warning about unhashed information added in in-toto/in-toto#288, remains uncovered. To not break tox builds, the required coverage threshold is lowered to 99% - This commit also enables output buffering on the unittest runner, i.e. to hide most of the test output until a test fails. See in-toto/in-toto#240 for details.
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this pull request
Aug 14, 2019
- Updates gpg tests to cover missing lines in gpg-subpackage. - One feature, a warning about unhashed information added in in-toto/in-toto#288, remains uncovered. To not break tox builds, the required coverage threshold is lowered to 99% - This commit also enables output buffering on the unittest runner, i.e. to hide most of the test output until a test fails. See in-toto/in-toto#240 for details.
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this pull request
Sep 4, 2019
- Updates gpg tests to cover missing lines in gpg-subpackage. - One feature, a warning about unhashed information added in in-toto/in-toto#288, remains uncovered. To not break tox builds, the required coverage threshold is lowered to 99% - This commit also enables output buffering on the unittest runner, i.e. to hide most of the test output until a test fails. See in-toto/in-toto#240 for details.
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this pull request
Sep 4, 2019
- Updates gpg tests to cover missing lines in gpg-subpackage. - One feature, a warning about unhashed information added in in-toto/in-toto#288, remains uncovered. To not break tox builds, the required coverage threshold is lowered to 99% - This commit also enables output buffering on the unittest runner, i.e. to hide most of the test output until a test fails. See in-toto/in-toto#240 for details.
tanishqjasoria
pushed a commit
to tanishqjasoria/securesystemslib
that referenced
this pull request
Jan 30, 2020
- Updates gpg tests to cover missing lines in gpg-subpackage. - One feature, a warning about unhashed information added in in-toto/in-toto#288, remains uncovered. To not break tox builds, the required coverage threshold is lowered to 99% - This commit also enables output buffering on the unittest runner, i.e. to hide most of the test output until a test fails. See in-toto/in-toto#240 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag subpackets being added to the info dict as hashed or unhashed so we can warn if the expiration subpacket is not hashed (don't merge yet still not fully functional)