Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise and update source code documentation and build with sphinx #369

Merged
merged 6 commits into from
Jun 23, 2020

Conversation

lukpueh
Copy link
Member

@lukpueh lukpueh commented Jun 16, 2020

Fixes issue #:
Mostly fixes #284

Description of the changes being introduced by the pull request:

See commit messages for details about the changes and https://in-toto-lukpueh.readthedocs.io/en/latest/ for the changes in action.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Revise/shorten/consolidate/update main API function-, class- and
method- docstrings:

 - verifylib.in_toto_verify
 - runlib.in_toto_run
 - runlib.in_toto_record_start
 - runlib.in_toto_record_stop
 - models.metadata.Metablock
 - models.link.Link
 - models.layout.Layout
 - models.layout.Step
 - models.layout.Inspection
 - models.common.Signable (only parts relevant for read the docs)
 - models.common.ValidationMixin (only relevant parts)

Changes custom Secure Systems Lab docstring format to Google
format, which is machine- (sphinx) and human-readable.
(Choosing Google over NumPy because it requires less vertical
space, see
https://sphinxcontrib-napoleon.readthedocs.io/en/latest/#google-vs-numpy)

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
+ revise and update

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
- Switch from alabaster to sphinx_rtd_theme
- Add napoleon sphinx extension to parse Google-style docstrings
- Add todo sphinx extension (for utils docs)
- Comment out currently unused html_static_path that triggered a
  warning

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Fix issues that occurred after swithing to sphinx-rtd-theme.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
+ some minor updates on the docs landing page, like pointers to
other in-toto resources.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Copy link
Member

@SantiagoTorres SantiagoTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me a little bit to get around to this. Nice commit evolution and changes. I'm pretty happy with the new rtd theme...

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise and consolidate documentation
2 participants