Adopt recent sslib key interface changes #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2020
This was referenced Nov 9, 2020
adityasaky
approved these changes
Nov 9, 2020
PR in-toto#402 adopted key interface changes from the pending secure-systems-lab/securesystemslib#288 PR and was merged prematurely. The sslib PR now has further evolved, in order to follow the principle of secure defaults in regards to private key encryption, which requires the following adoptions in in-toto: - The not secure by default generate_and_write_*_keypair function is now protected (_generate_and_write_*_keypair), and only used for the keygen cli utility, where it is really convenient. - In other cases we use either generate_and_write_*_keypair (for encrypted keys only) or generate_and_write_unencrypted_*_keypair. Furthermore, the newly added sslib key generation interface functions are added to the in-toto API docs. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
lukpueh
force-pushed
the
rm-util-refinishing
branch
from
69f3c2b
to
992e30c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Fixes issue #: #80
(Follows up on #402 to address recent changes in pending secure-systems-lab/securesystemslib#288)
Description of the changes being introduced by the pull request:
PR #402 adopted key interface changes from the pending secure-systems-lab/securesystemslib#288 PR and was merged prematurely. The sslib PR now has further evolved, in order to follow the principle of secure defaults in regards to private key encryption, which requires the following adoptions in in-toto:
The not secure by default
generate_and_write_*_keypairfunction is now protected (_generate_and_write_*_keypair), and only used for the keygen cli utility, where it is really convenient.In other cases we use either
generate_and_write_*_keypair(for encrypted keys only) orgenerate_and_write_unencrypted_*_keypair.Furthermore, the newly added sslib key generation interface functions are added to the in-toto API docs, including additional notes and cross-references relevant for key handling.
Please verify and check that the pull request fulfills the following
requirements: