Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add >=Py3.5 constraint for bandit test dependency #416

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

lukpueh
Copy link
Member

@lukpueh lukpueh commented Dec 7, 2020

Fixes issue #:

Description of the changes being introduced by the pull request:
Bandit just dropped support for Python <3.5. This PR adds a corresponding constraint to requirements-test.txt.

Note, we run bandit in a dedicated 'lint' tox environment, which uses Python3.8 on Travis.

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Bandit just dropped support for Python <3.5. This commit adds
a corresponding constraint to requirements-test.txt.

Note, we run bandit in a dedicated 'lint' tox environment, which
uses Python3.8 on Travis.

Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
@lukpueh
Copy link
Member Author

lukpueh commented Dec 7, 2020

I would say this change is minor enough to land without review. Merging...

@lukpueh lukpueh merged commit a6e867b into in-toto:develop Dec 7, 2020
@lukpueh lukpueh mentioned this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant