Add explicit utf8 encoding to "open" calls #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasaky
force-pushed
the
fix-lint-file-encoding
branch
from
73448be
to
7a85a92
Compare
adityasaky
changed the title
Signed-off-by: Aditya Sirish <aditya@saky.in>
adityasaky
force-pushed
the
fix-lint-file-encoding
branch
from
7a85a92
to
2e26ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
Fixes issue #: N/A
Description of the changes being introduced by the pull request:
Our linter is unhappy that we don't provide an explicit encoding when opening files in
Metablock.load. This PR sets the encoding to utf8.Please verify and check that the pull request fulfills the following
requirements: