Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable consider-using-f-string in pylint #473

Merged

Conversation

adityasaky
Copy link
Member

@adityasaky adityasaky commented Oct 12, 2021

Please fill in the fields below to submit a pull request. The more information
that is provided, the better.

Fixes issue #: N/A.

Description of the changes being introduced by the pull request:

Disables consider-using-f-string in pylint. Our style guideline recommends using both f-strings and the currently used .format mechanisms: https://github.com/secure-systems-lab/code-style-guidelines/blob/master/python.md#string-formatting, so IMO we shouldn't go and change the 94 (!) instances that the linter currently warns us about (https://github.com/in-toto/in-toto/pull/472/checks?check_run_id=3796490973).

Please verify and check that the pull request fulfills the following
requirements
:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Signed-off-by: Aditya Sirish <aditya@saky.in>
@adityasaky adityasaky force-pushed the ignore-f-string-recommendation branch from ec43268 to 2988050 Compare October 28, 2021 04:43
@adityasaky adityasaky merged commit 66f3ca5 into in-toto:develop Oct 28, 2021
@adityasaky adityasaky deleted the ignore-f-string-recommendation branch October 28, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant