Update for python 3.10 compatibility #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukpueh
requested changes
Dec 6, 2021
There was a problem hiding this comment.
Thanks for the contribution, @inglor! Would you mind adding 3.10 to CI/CD? IIRC, this should be a matter of patching...
in-toto/.github/workflows/ci.yml
Line 12 in fa124f2
and
Line 8 in fa124f2
Also, it would be nice if we performed the version case handling only once, e.g. define a global in common_args.py along the lines of:
OPTS_TITLE = "Optional Arguments" if sys.version_info < (3, 10) else "Options"which could be used in all other files (and maybe lower()ed in the usage texts)
Optional Arguments was renamed to Options in python 3.10 release [1] [1]: python/cpython#23858 Signed-off-by: Leonidas Spyropoulos <artafinde@gmail.com>
Seems like pylint 2.12.2 doesn't like the `keys()` anymore [1], [2] [1]: https://github.com/PyCQA/pylint/releases/tag/v2.12.2 [2]: https://pycodequ.al/docs/pylint-messages/c0201-consider-iterating-dictionary.html Signed-off-by: Leonidas Spyropoulos <artafinde@gmail.com>
|
Hi @lukpueh thanks for the review! Changes applied. I've modified the CI/CD to include 3.10 now - hope checks pass again :) |
Signed-off-by: Leonidas Spyropoulos <artafinde@gmail.com>
lukpueh
approved these changes
Dec 7, 2021
|
Many thanks, @inglor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Leonidas Spyropoulos artafinde@gmail.com
Please fill in the fields below to submit a pull request. The more information
that is provided, the better.
**Fixes issue #00:
N/A
Description of the changes being introduced by the pull request:
Fix compatibility with Python 3.10
Please verify and check that the pull request fulfills the following
requirements: