Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Address Trishank's review comments #6

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

SantiagoTorres
Copy link
Member

Although this diff seems minimal, I tried to address the following comments from @trishankkarthik:

Unanswered

  • There are too many terms upfront
  • Sections 2-3 are particularly redundant.
  • More picutres and diagrams are necessary (ASK)
  • POSIX timestamps
  • Point 8 of minor readability issues (ask trishank)
  • Why is there mention of private keys in the metadata?
  • Commands sound dangerous, are clients expected to run arbitrary commands? (ASK/Debate/FAQ)
  • What about rollback attacks? (Elaborate/question)

Answered/FIXED.

  • Disambiguate between functionaries and parties
  • Disambiguate between actors and roles
  • The website has no examples see updated website
  • Typos and style mismatches on section headers
  • Some mock sha256sums match when they shouldn't

@lukpueh
Copy link
Member

lukpueh commented Apr 17, 2019

I transferred the remaining items to #14. Merging/closing here.

@lukpueh lukpueh merged commit cea8f0d into metadata-samples Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants