Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: respond to weaknesses identified in the in-toto sec audit #268

Open
colek42 opened this issue Jun 14, 2023 · 0 comments
Open

security: respond to weaknesses identified in the in-toto sec audit #268

colek42 opened this issue Jun 14, 2023 · 0 comments
Labels
needs triage Issues to triage

Comments

@colek42
Copy link
Member

colek42 commented Jun 14, 2023

  1. Incorporate File Permissions into File Metadata Records

    • In response to the audit finding GHSA-wqrg-wjp9-wqfq, we need to include file permissions into file metadata records as part of the Omnitrail container development.
  2. Remove Support for Configuration Files

    • As per the audit finding GHSA-wqrg-wjp9-wqfq, we need to remove support for configuration files in Witness. Guidance should be provided on setting configurations through API parameters or CLI arguments.
  3. Add Feature to Attest Internal Configuration Parameters

    • In response to audit GHSA-wqrg-wjp9-wqfq, add a feature that attests to the Witness internal configuration parameters.
  4. Strategies to Counter Layout Replay Attacks

    • According to the audit finding GHSA-73jv-h86v-c2vh, implement strategies set out in in-toto Enhancements ITE-2 and ITE-3 leveraging The Update Framework (TUF). This includes adding TUF support to Archivista to ensure freshness of Witness Policy and other data stored.
  5. Implement Measures against Link File Reuse

    • As a response to the audit GHSA-6q78-j78h-pqm2, implement globally unique step names in a layout where reuse is not intended and reuse Witness policy across many pipelines as per recommendations from ITE-2 and ITE-3. Also, consider recording the hashes of the tool used in the step in the policy.
  6. Improve Verification by Functionaries

    • To address audit finding GHSA-p86f-xmg6-9q4x, support checking of witness policies before creating attestations and use namespaces and security modules like Seccomp, AppArmor, and SELinux to isolate Witness from the build process. This should be implemented alongside the existing Sigstore and SPIRE key providers.
  7. Clarify Position on PGP Support

    • As mentioned in response to audit GHSA-jjgp-whrp-gq8m, officially state and document that Witness neither supports nor plans to support PGP. This will ensure clarity for all users and contributors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issues to triage
Projects
None yet
Development

No branches or pull requests

2 participants