feat: standardize logging output #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, just needs docs regened and license headers. |
* Adds pkg/log library with logger interface * Adds cmd/log.go with logrus implementation of above interface configured * Logs errors that were being suppressed before and removes usage of log and fmt.Printf/Println in favor of using witness's logger. Signed-off-by: Mikhail Swift <mikhail@testifysec.com>
mikhailswift
force-pushed
the
feat/logging
branch
from
07b0d7d
to
26cf9a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configured
and fmt.Printf/Println in favor of using witness's logger.
Signed-off-by: Mikhail Swift mikhail@testifysec.com