fix: updating urls to in-toto from testifysec and -L to the curl for version
#297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank your for the contribution. Can we add the -L from #295 to make sure we redirect. |
lmco-seth
changed the title
in-toto from testifysecin-toto from testifysec and -L to the curl for version
Closed
|
@colek42 I see that two of the checks are failing currently. Looking at them they look to be around Fulcio failures when running Witness. Not really sure how to correct them as they seem unrelated to my changes. |
|
@lmco-seth yep, not an issue with your changes. I'm working on fixing that here. Github is protective with its tokens when running workflows from forks. As it should be. |
That makes sense. Was wondering if it was something with the permissions. Thank you for the confirmation! |
jkjell
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is to fix the github urls in the install-witness.sh file pointing to
testifysecresulting in breakages in the script. I tried to keep this change very simple by just updating to point toin-toto. This PR will also add a-Lto the curl for the latest release, used to get the version number. This will ensure that redirects happen when needed.This fixes #296 and #263
Please let me know if there are any issues with the change.