Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporarily disable omnitrail on windows builds #467

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

mikhailswift
Copy link
Collaborator

This updates go-witness to v0.5.2 which includes a build directive to disable compilation of the omnitrail attestor when targeting Windows.

What this PR does / why we need it

Description

Which issue(s) this PR fixes (optional)

(optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged)*

Fixes #

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

This updates go-witness to v0.5.2 which includes a build directive to
disable compilation of the omnitrail attestor when targeting Windows.

Signed-off-by: Mikhail Swift <mikhail@testifysec.com>
Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for witness-project ready!

Name Link
🔨 Latest commit 4241b4e
🔍 Latest deploy log https://app.netlify.com/sites/witness-project/deploys/666b6519c907910008ee5027
😎 Deploy Preview https://deploy-preview-467--witness-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mikhailswift mikhailswift merged commit 54e8d18 into main Jun 13, 2024
16 checks passed
@mikhailswift mikhailswift deleted the fix/disable-omnitrail-on-windows branch June 13, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants