perf: improve load timing for fonts (#53)

inabagumi · Nov 4, 2018 · 6840813 · 6840813
1 parent b363d58
commit 6840813
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 16 deletions.
diff --git a/src/app/app.component.html b/src/app/app.component.html
@@ -6,3 +6,7 @@
 </mat-toolbar>
 
 <router-outlet></router-outlet>
+
+<link href="https://fonts.googleapis.com/css?family=Roboto:300,400,500" rel="stylesheet">
+<link href="https://fonts.googleapis.com/css?family=Noto+Sans+JP:400,700" rel="stylesheet">
+<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
diff --git a/src/app/app.component.spec.ts b/src/app/app.component.spec.ts
@@ -21,10 +21,4 @@ describe('AppComponent', () => {
     const app = fixture.debugElement.componentInstance;
     expect(app).toBeTruthy();
   });
-
-  it(`should have as title 'neru-camera'`, () => {
-    const fixture = TestBed.createComponent(AppComponent);
-    const app = fixture.debugElement.componentInstance;
-    expect(app.title).toEqual('neru-camera');
-  });
 });
diff --git a/src/app/app.component.ts b/src/app/app.component.ts
@@ -5,6 +5,4 @@ import { Component } from '@angular/core';
   templateUrl: './app.component.html',
   styleUrls: ['./app.component.css']
 })
-export class AppComponent {
-  title = 'neru-camera';
-}
+export class AppComponent { }
diff --git a/src/app/camera/camera.component.css b/src/app/camera/camera.component.css
@@ -1,4 +1,5 @@
-.container {
+:host {
+  display: block;
   margin: 0;
   position: relative;
 }

diff --git a/src/app/camera/camera.component.html b/src/app/camera/camera.component.html
@@ -1,4 +1,5 @@
-<div class="container" *ngIf="!failed; then thenBlock; else elseBlock"></div>
+<ng-container *ngIf="!failed; then thenBlock; else elseBlock">
+</ng-container>
 
 <ng-template #thenBlock>
   <canvas

diff --git a/src/index.html b/src/index.html
@@ -30,9 +30,6 @@
   </head>
   <body>
     <app-root></app-root>
-    <noscript><p>Please enable JavaScript to continue using this application.</p></noscript>
-    <link href="https://fonts.googleapis.com/css?family=Roboto:300,400,500" rel="stylesheet">
-    <link href="https://fonts.googleapis.com/css?family=Noto+Sans+JP:400,700" rel="stylesheet">
-    <link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
-</body>
+    <noscript><p>JavaScript を有効にしてください。</p></noscript>
+  </body>
 </html>