Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#34] logger behaviour #36

Closed
wants to merge 2 commits into from
Closed

[#34] logger behaviour #36

wants to merge 2 commits into from

Conversation

flaviogranero
Copy link
Member

fixes #34

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 88.696% when pulling 64d4dff on flavio.34.logger-behaviour into 08afe38 on master.

alemata
alemata reviewed May 13, 2016
View reviewed changes
lib/dayron/adapter.ex
@@ -15,13 +15,12 @@ defmodule Dayron.Adapter do
end
end
"""
require HTTPoison
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flaviogranero I am not sure why this changes appear here if I already merge #35

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 88.696% when pulling 78828b1 on flavio.34.logger-behaviour into 87b7451 on master.

@flaviogranero
Copy link
Member Author

ready @alemata

@flaviogranero flaviogranero deleted the flavio.34.logger-behaviour branch May 16, 2016 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alemata alemata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract logger to an behavior
3 participants
@flaviogranero @coveralls @alemata