[#33] inspect request response, better logging #37

flaviogranero · 2016-05-16T18:01:47Z

fixes #33
fixes #34

…er from application config

…er, exceptions receiving request/response structs

…ving request test coverage

…adding tests

…basic_logger unit tests. fixing credo warnings.

coveralls · 2016-05-16T18:03:56Z

Coverage increased (+8.2%) to 98.496% when pulling 21be1c0 on flavio.33.inspect-request-response into 87b7451 on master.

alemata · 2016-05-16T18:25:34Z

lib/dayron/request.ex

+  defp time_diff(start, stop), do: :timer.now_diff(stop, start)
+end
+
+defimpl Inspect, for: Dayron.Request do


@flaviogranero what do you think about moving the inspect implementations to another file?

@alemata I'm not sure, why?

It was just an idea, to keep things separated.... but I am ok with leaving them there!

since it's related to Request module, I think it's good to have everything in a single file..

flaviogranero added 6 commits May 12, 2016 17:52

[#34] adding logger behavior, implementing basic logger, loading logg…

64d4dff

…er from application config

[#33] more refactoring in repo functions, Config.parse returning logg…

164dfb5

…er, exceptions receiving request/response structs

[#33] implementing Inspect with pretty:true for Request module, impro…

fa67e75

…ving request test coverage

[#33] implementing Inspect protocol for Response with pretty option, …

9ef89bb

…adding tests

[#33] Request.send storing response elapsed_time

54c6545

[#33] basic_logger using pretty inspect, printing exception message. …

21be1c0

…basic_logger unit tests. fixing credo warnings.

flaviogranero assigned alemata May 16, 2016

alemata reviewed May 16, 2016
View reviewed changes

alemata merged commit 38f24ee into master May 16, 2016

flaviogranero deleted the flavio.33.inspect-request-response branch May 16, 2016 19:05

Provide feedback