Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding __from_json_list__/2 in Model #60

Merged
merged 2 commits into from Oct 27, 2016
Merged

Allow overriding __from_json_list__/2 in Model #60

merged 2 commits into from Oct 27, 2016

Conversation

jcypret
Copy link
Contributor

@jcypret jcypret commented Oct 16, 2016

This allows overriding the root-level key in the json response for scenarios where the array of records is nested inside of an attribute, such as data.

@jcypret
Allow overriding __from_json_list__/2 in Model
fde6144 
This allows overriding the root-level key in the json response for scenarios where the array of records is nested inside of an attribute, such as `data`.
@jcypret
Merge branch 'master' into jc-override-from-json-list
86af99e
@jcypret jcypret mentioned this pull request Oct 16, 2016
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 86af99e on jcypret:jc-override-from-json-list into 6d06d94 on inaka:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 86af99e on jcypret:jc-override-from-json-list into 6d06d94 on inaka:master.

@flaviogranero
Copy link
Member

thank you @jcypret! merging this, I'll create a new release soon.

@flaviogranero flaviogranero merged commit 28689fe into inaka:master Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcypret @coveralls @flaviogranero