Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StringDictionary typealias #28

Closed
volbap opened this issue May 23, 2016 · 2 comments
Closed

Remove StringDictionary typealias #28

volbap opened this issue May 23, 2016 · 2 comments

Comments

@volbap
Copy link
Contributor

volbap commented May 23, 2016

Proposal:

  • Remove typealias StringDictionary = [String: AnyObject]

Reasoning:

  • This typealias does not add real convenience but only confusion. Having to type StringDictionary vs. [String: AnyObject] does not make much of a difference, and the former adds the hesitation of "what does it really is?" to any customer using the library, whereas the latter is clearer because it's explicit.
@volbap
Copy link
Contributor Author

volbap commented May 23, 2016

⚠️ Watch out for documentation updates and compatibility issues.

@volbap
Copy link
Contributor Author

volbap commented May 26, 2016

Renaming process checklist:

  • Every appearance in code is renamed
  • Every according file is renamed
  • Project builds successfully
  • Tests pass successfully
  • There's a deprecation/migration mechanism implemented in code
  • README is updated
  • CHANGELOG is updated

volbap pushed a commit that referenced this issue May 26, 2016
volbap pushed a commit that referenced this issue May 26, 2016
volbap pushed a commit that referenced this issue May 26, 2016
@volbap volbap mentioned this issue May 26, 2016
@volbap volbap closed this as completed May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant