Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error on R16B03-01 and R15B03 #59

Closed
pnc opened this issue Jun 18, 2015 · 1 comment
Closed

Build error on R16B03-01 and R15B03 #59

pnc opened this issue Jun 18, 2015 · 1 comment

Comments

@pnc
Copy link
Contributor

pnc commented Jun 18, 2015

Thanks for the great library! We've been running it in production for three or four years with great success.

It looks like the change (bd9048e) to use queue:queue() as a type rather than plain queue() might have broken the build on releases older than R17:

ERLC   apns.erl apns_queue.erl apns_sup.erl apns_connection.erl
src/apns_queue.erl:32: referring to built-in type queue as a remote type; please take out the module name
src/apns_queue.erl:111: referring to built-in type queue as a remote type; please take out the module name
make: *** [ebin/apns.app] Error 1

It looks like the OTP team knew this would be a backwards-incompatible change and introduced a compiler option to suppress the warning, which might be more appropriate than switching to the new type (at least until R18 is released): http://erlang.org/pipermail/erlang-questions/2014-March/078081.html

If support for older releases (R14, 15, and 16, as defined in the rebar.config) is still desired, is it possible to use a preprocessor guard around the new types? We don't use types in our Erlang app, so I'm unsure here.

Here are the build results from three OTP versions: https://travis-ci.org/eleostech/apns4erl/builds/67406167

@ferigis
Copy link
Member

ferigis commented Feb 13, 2017

currently we only support 19+. We can close that ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants