Important refactorization #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ferigis
commented
Jan 31, 2017
ferigis
commented
- Improving response handler [close Handling responses improvement #138]
- Connection to APNs synchronised
- improve the mocks on tests mocking gun always
elbrujohalcon
requested changes
Feb 1, 2017
src/apns_connection.erl
Outdated
| -spec init(connection()) -> {ok, State :: state()}. | ||
| init(Connection) -> | ||
| -spec init(list()) -> {ok, State :: state()}. | ||
| init([Connection, Client]) -> |
There was a problem hiding this comment.
In general, when you have something that has a fixed number of elements, you use a tuple ({Connection, Client}) not a list.
src/apns_connection.erl
Outdated
| {GunMonitor, GunConnectionPid} = open_gun_connection(Connection), | ||
| % wait until the connection is established | ||
| self() ! {wait_gun_up, Client}, |
There was a problem hiding this comment.
Can you use 0 timeout mechanism instead of self messaging here?
elbrujohalcon
approved these changes
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.