Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to use apns4erl and cowboy 1 in the same release? #162

Merged
merged 2 commits into from
Apr 17, 2017

Conversation

elbrujohalcon
Copy link
Member

apns4erl depends on gun (master), and gun depends on cowlib (master) and uses cowlib_http2, which is only available in cowlib 2.0.0-pre. Cowboy 1.1.2 depends on cowlib 1.0.2, which doesn't have cowlib_http2 module.

I can't include both cowlib 2.0.0-pre and cowlib 1.0.2 into the same release. It means, I can use both cowboy 1 and apns4erl in my project. Is there any workaround?

@yzh44yzh
Copy link
Author

yzh44yzh commented Apr 17, 2017

I see 5 options:

  • switch project to cowboy 2
  • fork apns4erl, gun, cowlib, rename modules in cowlib, use new names in gun
  • try to use elixir lib (apns or pigeon) in erlang project
  • run apns4erl in other node
  • write my own apns library

@elbrujohalcon
Copy link
Member

@yzh44yzh I see your problem, and sadly I don't have a good solution for it.
apns4erl depends heavily on cowlib_http2.
One thing we can do, although totally unrelated to your project, is to replace master in rebar.config by a git SHA.

And from your list of options, Elixir's apns is internally the same as apns4erl 1.0.6-final.

@elbrujohalcon
Copy link
Member

Sorry for hijacking your issue, @yzh44yzh :$
It's the way aw works :/

@ferigis ferigis merged commit e362e0e into master Apr 17, 2017
@yzh44yzh
Copy link
Author

Thanks for quick reply

@yzh44yzh
Copy link
Author

Some info about elixir libs:

https://hex.pm/packages/apns uses its own implementation of http2
https://hex.pm/packages/pigeon uses kadabra http2 client (https://hex.pm/packages/kadabra)

They both don't depend on cowlib.

@ferigis ferigis deleted the elbrujohalcon.162.is_it_possible_to_use_apns4erl branch June 27, 2017 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants