Allow binary cert/key in apns_connection like v1 #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elvisci
reviewed
Jul 10, 2017
src/apns_connection.erl
Outdated
| -type type() :: cert | token. | ||
| -type type() :: certdata | cert | token. | ||
| -type keydata() :: {'RSAPrivateKey' | 'DSAPrivateKey' | 'ECPrivateKey' | 'PrivateKeyInfo' | ||
| ,binary()}. |
elvisci
reviewed
Jul 10, 2017
src/apns_connection.erl
Outdated
| @@ -58,11 +60,15 @@ | |||
| -type host() :: string() | inet:ip_address(). | |||
| -type path() :: string(). | |||
| -type notification() :: binary(). | |||
| -type type() :: cert | token. | |||
| -type type() :: certdata | cert | token. | |||
| -type keydata() :: {'RSAPrivateKey' | 'DSAPrivateKey' | 'ECPrivateKey' | 'PrivateKeyInfo' | |||
There was a problem hiding this comment.
Line 64 is too long: -type keydata() :: {'RSAPrivateKey' | 'DSAPrivateKey' | 'ECPrivateKey' | 'PrivateKeyInfo'.
ferigis
requested changes
Jul 11, 2017
src/apns_connection.erl
Outdated
| @@ -256,10 +278,18 @@ host(#{apple_host := Host}) -> | |||
| port(#{apple_port := Port}) -> | |||
| Port. | |||
|
|
|||
| -spec cert(connection()) -> binary(). | |||
| cert(#{certdata := Cert}) -> | |||
There was a problem hiding this comment.
this getter function should be called certdata/1
src/apns_connection.erl
Outdated
| -spec certfile(connection()) -> path(). | ||
| certfile(#{certfile := Certfile}) -> | ||
| Certfile. | ||
|
|
||
| -spec key(connection()) -> keydata(). | ||
| key(#{keydata := Key}) -> |
There was a problem hiding this comment.
this getter function should be called keydata/1
|
Hi @danielfinke Thanks for your contribution! :) I have requested two little changes. You could add a test with your new feature. after that we will merge it |
ferigis
approved these changes
Jul 11, 2017
|
Thanks! |
|
@danielfinke merged. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store the APNS provider cert/key in a shared database, so we prefer to be able to supply this information directly to the apns4erl library, avoiding a file on disk.
This PR adds back support (previously in v1) to set cert/key binary data on the apns_connection.