Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import code coverage plugins as project plugins #231

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

dsrosario
Copy link
Collaborator

By importing the plugins as project plugins we don't impose them to the
consumer that depends on this project.

By importing the plugins as project plugins we don't impose them to the
consumer that depends on this project.
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #231 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files           7        7           
  Lines         217      217           
=======================================
  Hits          190      190           
  Misses         27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3aba9e...21f9459. Read the comment docs.

Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@ferigis ferigis merged commit dd08f56 into inaka:master Aug 12, 2020
@ferigis
Copy link
Member

ferigis commented Aug 12, 2020

thanks for your contribution @dsrosario !

@dsrosario
Copy link
Collaborator Author

You’re welcome. It is possible to have a release with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants