Remove env-section from apns.app.src #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It was intended to act as a config sample and poor-man's documentation. If you really need to remove it, please add an |
|
BTW, just in case, you can load an app without starting it, like… application:load(apns),
application:set_env(apns, cert_file, "your/cert.pem"),
apns:start(). |
|
I've added a default app.config to the PR. |
The env-section effectively overrides any value set using application:set_env/3 before apns is loaded making it harder to test, etc. The data in env doesn't really add anyhing since the user most definitely want to update that with it's own info A default app.config is added to priv/app.config
elbrujohalcon
pushed a commit
that referenced
this pull request
Oct 20, 2014
Remove env-section from apns.app.src
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The env-section effectively overrides any value set using
application:set_env/3 before apns is loaded making it harder to test,
etc. The data in env doesn't really add anyhing since the user most
definitely want to update that with it's own info