APNS resend queue #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {stop, normal, State}; | ||
|
|
||
| handle_cast({in, Msg}, #state{max_entries=MaxEntries,queue=OldQueue}=State) -> | ||
| Queue = case MaxEntries =< ?QUEUE:len(OldQueue) of |
There was a problem hiding this comment.
We would prefer avoiding using macros for function or module names.
|
Fixed: altenwald/apns4erl@b59e7a0 |
|
@manuel-rubio somehow that commit did not get into the PR |
|
Added into pull request |
|
|
||
| handle_cast({in, Msg}, #state{max_entries=MaxEntries,queue=OldQueue}=State) -> | ||
| Queue = case MaxEntries =< queue:len(OldQueue) of | ||
| true -> queue:liat(OldQueue); |
There was a problem hiding this comment.
Just as a comment, I would avoid the Okasaki version of the queue api.
|
Looks good, some tests would be welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #17
Commit is adopted for version 1.0.2 from two commits:
altenwald@06431ef
altenwald@618e52c