Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Elvis version configurable #15

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

andrei-mihaila
Copy link
Contributor

  • just add ELVIS_VERSION = <major.minor.revision> to your Makefile
  • had to change the way Elvis is pulled in
    • pull the tar.gz archive from Github
    • unarchive
    • build with rebar3
    • this means there will no longer be compatibility issues because of the Erlang / OTP version
    • but might be brittle because it relies on the rebar3 command being available ...

- just add `ELVIS_VERSION = <major.minor.revision>` to your Makefile
- had to change the way Elvis is pulled in
  - pull the tar.gz archive from Github
  - unarchive
  - build with rebar3
  - this means there will no longer be compatibility issues because of the Erlang / OTP version
  - but might be brittle because it relies on the rebar3 command being available ...
@elbrujohalcon elbrujohalcon merged commit bb60fdb into inaka:master Aug 8, 2022
@elbrujohalcon
Copy link
Member

@andrei-mihaila thanks for the pull request. The truth is we (@inaka) are not actively maintaining this repo anymore. Since you seem to be an active user, do you want me to transfer it to your account so you can inherit and maintain it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants