Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test over OTP 27 and rebar3 3.23 #341

Merged
merged 5 commits into from
May 22, 2024
Merged

Test over OTP 27 and rebar3 3.23 #341

merged 5 commits into from
May 22, 2024

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented May 21, 2024

Notes on pull request

Found issues are around the development and maintenance of this library and rebar3_format. They do not seem to indicate elvis_core as non- OTP-27-ready.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Since this is now forbidden in OTP 27

===> Compiling elvis_core
compile: warnings being treated as errors
compile: warnings being treated as errors
/home/runner/work/elvis_core/elvis_core/test/examples/fail_no_successive_maps.erl:6:22: expression updates a literal
%    6|     M = #{this => is}#{wrong => "and"},
%     |                      ^

/home/runner/work/elvis_core/elvis_core/test/examples/pass_no_successive_maps_elvis_attr.erl:8:22: expression updates a literal
%    8|     M = #{this => is}#{wrong => "and"},
%     |                      ^

we might have to tweak the tests (macros 🎉) and think about dropping this check in the future 😄

@paulo-ferraz-oliveira
Copy link
Collaborator Author

rebar3 format --verify fails for OTP 24, but if I format the files with OTP 24 it then fails for OTP 27 😕

@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented May 21, 2024

To move forward, I propose (thoughts?) we move the minimum supported version to 25.

At the same time, though, the formatter moves -else. to - else . which is consumable but not pretty 😄

I propose CI only checks formatting when OTP 26, since 27 breaks it (actually, it seems 25 already broke it). This is an important change in Erlang/OTP in any case, but an issue for rebar3_format, not this repository (you already have AdRoll/rebar3_format#359).

After that the formatter breaks CI
@elbrujohalcon elbrujohalcon merged commit 15c909d into main May 22, 2024
18 checks passed
@elbrujohalcon elbrujohalcon deleted the feature/otp-27 branch May 22, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants