Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header files: 'should not include' and 'could include' #20

Closed
amilkr opened this issue Sep 25, 2014 · 8 comments
Closed

Header files: 'should not include' and 'could include' #20

amilkr opened this issue Sep 25, 2014 · 8 comments
Assignees
@igaray
Labels
rule A new rule to add. started

Comments

@amilkr
Copy link
Contributor

amilkr commented Sep 25, 2014

rule

Header files should not include type definitions nor record definitions nor function definitions.
Header files could include macros definitions.
@elbrujohalcon
Copy link
Member

+1

2 similar comments
@jfacorro
Copy link
Contributor

jfacorro commented Oct 8, 2014

+1

@igaray
Copy link
Member

igaray commented Oct 21, 2014

+1

@elbrujohalcon
Copy link
Member

@amilkr can you make a PR from this, please?

@elbrujohalcon
Copy link
Member

@amilkr we're still waiting for the PR

@elbrujohalcon
Copy link
Member

@amilkr …

@elbrujohalcon
Copy link
Member

@amilkr any time you want, man

@HernanRivasAcosta
Copy link
Member

@amilkr?

@igaray igaray self-assigned this Mar 7, 2018
@igaray igaray added started rule A new rule to add. labels Mar 7, 2018
elbrujohalcon added a commit that referenced this issue Mar 7, 2018
@elbrujohalcon
Merge pull request #83 from inaka/20.igaray.header_file_guidelines
6bc6396 
[FIXES #20] Add header guidelines
igaray added a commit that referenced this issue Mar 7, 2018
@igaray
[FIXES #20] Add header guidelines
2176b35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igaray igaray

Labels
rule A new rule to add. started
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@elbrujohalcon @igaray @amilkr @jfacorro @HernanRivasAcosta