Support maybe syntax #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great addition, @sile ! Thank you :) |
elbrujohalcon
approved these changes
May 10, 2022
Closed
|
Thank you for your quick response! |
|
If you don't mind, I will not generate a new release just yet. I'll do it once OTP25 is released next week and it will hopefully include #70 as well. |
|
No problem! Thank you for letting me know your release schedule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm a user of
rebar3_lintand have a problem that the tool cannot handle the maybe feature that planned to be introduced in OTP-25 (I'm currently using OTP-25 rc3).With some debugging and code reading, I found out that by adding the maybe support to this library,
rebar3_lintcould also support that.This PR contains the diff needed to support the maybe feature.