Merge pull request #61 from inaka/elbrujohalcon.61.compatibility_with…

…_otp19_

Compatibility with OTP19+

rebar.config

@@ -28,11 +28,6 @@
     {deps, [
       {elvis_core,  {git, "https://github.com/inaka/elvis_core.git",  {tag, "0.2.11"}}}
     ]}
-  ]},
-  {shell, [
-    {deps, [
-      {sync, {git, "https://github.com/rustyio/sync.git", {ref, "9c78e7b"}}}
-    ]}
   ]}
 ]}.
 
@@ -66,26 +61,23 @@
 
 %% == Dependencies ==
 
-{deps, [{getopt, "0.8.2"}]}.
+{deps, [{getopt, "1.0.1"}]}.
 
 %% == Dialyzer ==
 
 {dialyzer, [
     {warnings, [ unmatched_returns
                , error_handling
+               , unknown
                ]},
     {get_warnings, true},
     {plt_apps, top_level_deps},
-    {plt_extra_apps, []},
+    {plt_extra_apps, [erts, kernel]},
     {plt_location, local},
     {base_plt_apps, [stdlib, kernel]},
     {base_plt_location, global}
 ]}.
 
-%% == Shell ==
-
-{shell, [{apps, [sync]}]}.
-
 %% == Escriptize ==
 
 {escript_name, "xrefr"}.

rebar.lock

@@ -1,6 +1,6 @@
 {"1.1.0",
-[{<<"getopt">>,{pkg,<<"getopt">>,<<"0.8.2">>},0}]}.
+[{<<"getopt">>,{pkg,<<"getopt">>,<<"1.0.1">>},0}]}.
 [
 {pkg_hash,[
- {<<"getopt">>, <<"B17556DB683000BA50370B16C0619DF1337E7AF7ECBF7D64FBF8D1D6BCE3109B">>}]}
+ {<<"getopt">>, <<"C73A9FA687B217F2FF79F68A3B637711BB1936E712B521D8CE466B29CBF7808A">>}]}
 ].

src/xref_runner.app.src

@@ -8,6 +8,7 @@
     , stdlib
     , tools
     , erl_interface
+    , getopt
     ]},
    {modules, []},
    {registered, []},

test/xref_runner_SUITE.erl

@@ -76,7 +76,7 @@ check_rebar3_build_fail(_Config) ->
   _ = rebar3_compile(RepoName),
   [Warning] = xref_runner:check(),
 
-  #{ line      := 9
+  #{ line      := 11
    , check     := undefined_function_calls
    , filename  := Filename
    , source    := {erlang_repo_fail_sup, init, 1}

test_examples/erlang-repo-fail/src/erlang_repo_fail_app.erl

@@ -4,9 +4,11 @@
 -export([start/2]).
 -export([stop/1]).
 
+-spec start(_, [term()]) -> {ok, pid()}.
 start(_Type, _Args) ->
-    erlang_repo_fail_sup:start_link().
+  erlang_repo_fail_sup:start_link().
 
+-spec stop(_) -> ok.
 stop(_State) ->
-    ok.
+  ok.
 

test_examples/erlang-repo-fail/src/erlang_repo_fail_sup.erl

@@ -3,10 +3,12 @@
 
 -export([start_link/0, init/1]).
 
+-spec start_link() -> {ok, pid()}.
 start_link() ->
-    supervisor:start_link({local, ?MODULE}, ?MODULE, []).
+  supervisor:start_link({local, ?MODULE}, ?MODULE, noargs).
 
-init([]) ->
-    Procs = [],
-    erlang_repo_fail_app:non_exist_function(),
-    {ok, {{one_for_one, 1, 5}, Procs}}.
+-spec init(noargs) -> {ok, {supervisor:sup_flags(), [supervisor:child_spec()]}}.
+init(noargs) ->
+  Procs = [],
+  erlang_repo_fail_app:non_exist_function(),
+  {ok, {{one_for_one, 1, 5}, Procs}}.

test_examples/erlang-repo/src/erlang_repo_app.erl

@@ -4,9 +4,11 @@
 -export([start/2]).
 -export([stop/1]).
 
+-spec start(_, [term()]) -> {ok, pid()}.
 start(_Type, _Args) ->
-    erlang_repo_sup:start_link().
+  erlang_repo_sup:start_link().
 
+-spec stop(_) -> ok.
 stop(_State) ->
-    ok.
+  ok.
 

test_examples/erlang-repo/src/erlang_repo_sup.erl

@@ -3,9 +3,11 @@
 
 -export([start_link/0, init/1]).
 
+-spec start_link() -> {ok, pid()}.
 start_link() ->
-    supervisor:start_link({local, ?MODULE}, ?MODULE, []).
+  supervisor:start_link({local, ?MODULE}, ?MODULE, noargs).
 
-init([]) ->
-    Procs = [],
-    {ok, {{one_for_one, 1, 5}, Procs}}.
+-spec init(noargs) -> {ok, {supervisor:sup_flags(), [supervisor:child_spec()]}}.
+init(noargs) ->
+  Procs = [],
+  {ok, {{one_for_one, 1, 5}, Procs}}.