* Add support of wildcards in xref.config paths. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NOMORECOFFEE great addition! Can you add a test case for this, please? |
|
@elbrujohalcon ok. Sorry for delay. |
|
@NOMORECOFFEE : Not to push you, but… were you able to add some tests here? |
| match_one_character_dir_with_subdir(Config) -> | ||
| PrivDir = ?config(priv_dir, Config), | ||
| Dirs = [filename:join([PrivDir, "?", "ebin"])], | ||
| ?assertEqual(["a", "b", "c"], basenames(dirnames(xref_runner:find_dirs(Dirs)))). |
There was a problem hiding this comment.
According to Elvis:
Line 53 is too long: ?assertEqual(["a", "b", "c"], basenames(dirnames(xref_runner:find_dirs(Dirs))))..
|
@NOMORECOFFEE please don't use eunit. We are already using common_test in this project. |
|
|
||
| match_alternatives_with_subdir(Config) -> | ||
| PrivDir = ?config(priv_dir, Config), | ||
| Dirs = [filename:join([PrivDir, "{a,dd}", "ebin"])], |
There was a problem hiding this comment.
According to Elvis:
Missing space after "," on line 99
|
So awesome! |
elbrujohalcon
pushed a commit
that referenced
this pull request
Aug 25, 2015
* Add support of wildcards in xref.config paths.
|
|
||
| match_alternatives_with_subdir(Config) -> | ||
| PrivDir = ?config(priv_dir, Config), | ||
| Dirs = [filename:join([PrivDir, "{a,dd}", "ebin"])], |
There was a problem hiding this comment.
According to Elvis:
Missing space after "," on line 80
|
@elbrujohalcon thank! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an example:
[ {xref, [ {config, #{ dirs => ["apps/*/ebin"], extra_paths => ["deps/*/ebin"] }}, {checks, [ undefined_function_calls , undefined_functions , locals_not_used , exports_not_used , deprecated_function_calls , deprecated_functions ]} ] } ].