Maintenance updates #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before starting to change files in the scope of this branch
Don't know how this wasn't an issue before, with us pattern matching against an opaque structure, but it is now Solution is not the most elegant, but is enough for tests Will wait for review comments to potentially update this
Only keep generated stuff + _* (e.g. for _build and _checkouts)
This option used to exist, but not any more
For OTP 26 we get several functions as unknown (since this is the new default). However, adding no_unknown to dialyzer options for OTP 24 and 25 errors out, so this is an Ok compromise, I guess
There was a problem hiding this comment.
LGTM, but I would not merge this PR without @jfacorro's reviewal.
The README.md fix (for reference) is just a bonus!
elbrujohalcon
approved these changes
Aug 24, 2023
|
Any chance this gets reviewed soon? |
|
Well… a month has passed… 🤷🏻 … let's move forward, then! |
|
There you go: https://hex.pm/packages/zipper/1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't as big as it looks, though there's possibly a lotta changes.
I'll self-review and try to guide you through it to ease the task.
Whenever a change is not super-explicit or supported by the commit message I'll add a comment.