Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "enabled" configuration variable #8

Closed
3 tasks done
inakianduaga opened this issue Nov 14, 2014 · 0 comments
Closed
3 tasks done

Add "enabled" configuration variable #8

inakianduaga opened this issue Nov 14, 2014 · 0 comments

Comments

@inakianduaga
Copy link
Owner

We need an "enabled" configuration variable that is true by default for both loggers. That way they can be dynamically disabled.

  • Add a check for the flag in the code, if it's disabled it should do nothing, except return back the chain
  • Update mock configuration/readme with examples
  • Add tests for the disable case to make sure nothing is happening when disabled. Also add tests to dynamically toggle and make sure it works after reenabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant