Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite settings implementation: Use predefined static configurations #12

Open
inakianduaga opened this issue Feb 5, 2015 · 2 comments

Comments

@inakianduaga
Copy link
Owner

Instead of passing the settings per request (too much overhead, too unconventional for documenting/implementing), we do the following

  • Optionally provide a json file with configuration groups by keys (so angular-project1 : ... would be a set of configuration that we can access through angular-project1 key, etc). These definitions live on the server and must be hardcoded into the application (NOT the repo)
  • The post route for logging has a parameter that will accept a configuration key string. If it's empty or it doesn't match a configuration, the default configuration will be used, otherwise we will extend the default configuration with the preconfigured key one.
  • Same for the get method to retrieve an effective configuration.

This is much better since it's very simple to implement on the client side (no extra parameters on the client side), has no overhead on the log requests, and basically makes sense since the server will usually take logging from a small set of applications that can be preconfigured instead of some random request that would need really dynamic configuration

@inakianduaga
Copy link
Owner Author

TODO

On services/settings.ts we need to replace the old requestHeaderSettingsField parameter by the group id and build the config using that

inakianduaga pushed a commit that referenced this issue Aug 21, 2015
inakianduaga pushed a commit that referenced this issue Aug 22, 2015
@inakianduaga
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant