Skip to content
This repository has been archived by the owner on Dec 12, 2021. It is now read-only.

Fix multiple next-producer call bug #4

Merged
merged 2 commits into from
Oct 25, 2016
Merged

Fix multiple next-producer call bug #4

merged 2 commits into from
Oct 25, 2016

Conversation

inamiy
Copy link
Owner

@inamiy inamiy commented Oct 24, 2016

Fixed multiple next-producer call bug as discussed in #3.

@inamiy inamiy added the bug label Oct 24, 2016
@inamiy inamiy mentioned this pull request Oct 24, 2016
Closed
AndrewSB
AndrewSB approved these changes Oct 24, 2016
View reviewed changes
Copy link
Contributor

@AndrewSB AndrewSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome 😄 `shareReplay(1) makes complete sense.
It may also make sense to add another test that makes sure a second state transition re-subscribes to the Observable, and doesn't immediately get fed the replay

@inamiy
Copy link
Owner Author

inamiy commented Oct 25, 2016

@AndrewSB Thanks for check!

@inamiy inamiy merged commit 8149b2d into swift/3.0 Oct 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewSB AndrewSB AndrewSB approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@inamiy @AndrewSB