Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display representative guide photos alongside guide tag values #48

Closed
loarie opened this issue May 6, 2015 · 4 comments
Closed

Display representative guide photos alongside guide tag values #48

loarie opened this issue May 6, 2015 · 4 comments
Assignees

Comments

@loarie
Copy link
Member

loarie commented May 6, 2015

Kew is interested in using the tags infrastructure on guides as an identification key. I've played with doing that here: http://www.inaturalist.org/guides/1503

On the server, we will allow users to add tags to Guide Photos. Guide Photos with a tag like Present-in-NoCA?=yes* (ie matching one of the guide tag key-values and followed by an *) will indicate that they should be displayed alongside the appropriate tag value in the filter sidebar on the app. For instance, these images could display as modals when clicking on information icons something like this:
screen shot 2015-04-30 at 11 33 47 am

The server side piece of this issue is here
inaturalist/inaturalist#542

@joellebel
Copy link
Collaborator

It would be great if the photo could open up in the same viewer we use to view photos, but with a white background instead of black for consistency. However, it doesn't need the info button in the bottom center or the more menu in the upper top right.

Let me know if you need a screenshot of what I'm talking about.

@kueda
Copy link
Member

kueda commented Aug 14, 2015

@budowski, server side changes for this have been added. Basically <GuidePhoto> elements in the XML now have tags (used to be only <GuideTaxon> elements). To find an image illustrating a particular <GuideTaxon> tag, look a <tag> element with the same predicate or inner text.

Example: http://www.inaturalist.org/guides/1503.xml has a number of <GuideTaxon> elements with <tag predicate="Number of articles in flagellum of antenna two" namespace="" value="2">Number of articles in flagellum of antenna two=2</tag> tags, but there is at least one <GuidePhoto> element that contains <tag predicate="Number of articles in flagellum of antenna two" namespace="" value="2">Number of articles in flagellum of antenna two=2</tag> as well.

I went a little off-spec and abandoned the asterisk, so the expectation now is that the app should show the first <GuidePhoto> that has the same tag. Hope that makes sense.

@budowski
Copy link
Contributor

@kueda - Awesome, I'll let you know of any issues/questions :-)
@joellebel - So basically the photo viewer will be a new screen (and not a floating layout like in the mockup), right? Also, could you please send me the info icon asset? Thanks :-)

@joellebel
Copy link
Collaborator

@budowski Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants