Dynamic Life List: Sorting obs by "Date Added" actually sorts of "Date Observed"

[tiwane]

Go to https://www.inaturalist.org/lifelists/tiwane?view=tree&details_view=observations&tree_mode=full_taxonomy&taxon_id=1 which should show all my animal observations sorted by "Date Added", oldest to newest. However, the first observation is this one, which was added in 2012. The first animal observation I added is this one, which appears third.

We should either change the label to "Date observed" or actually sort by "Date added" - I'd prefer the latter since the default is to sort by "Date added", newest to oldest.

[fredunit]

Can I claim this problem? and do you mean change the capitalized Added to added?

[kueda]

@fredunit, go for it. I'd just use whatever version of "date added" we already have translated. Holler if you have trouble getting a working dev env.

[fredunit]

So, this mean the function is not correct, and I need to review the logic behind and change it, am I right?

[kueda]

The changes in https://github.com/inaturalist/inaturalist/pull/3111/files don't really change the "logic" of anything, they just change the capitalization of three strings. The problem described in this issue is that the sort order on Tony's life list is not by "date added" as the interface claims, so the cause of the incorrect sorting needs to be investigated. Maybe that means the API request needs a different parameter, maybe that means the API is broken somehow. If the former, that should be a straightforward fix. If the latter, we need to fix the API, which is probably beyond the scope of this issue.

[fredunit]

So, which @tiwane described is the image first submitted should be showed at first one, because the oldest to newest should be base on the date submitted rather than date observed, am I correct?

[kueda]

Yes, if the sort order says "Date Added" then the results should be sorted in that order. The important result to achieve is that the UI text should describe what is actually happening.

[elysiumplain]

Very old issue - looking at UI and ref adam-rankn@9c6cb74 it seems resolved. Want to close, @tiwane ?