Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User's locale affecting AM/PM of some observations #3437

Closed
tiwane opened this issue May 3, 2022 · 1 comment · Fixed by #3450
Closed

User's locale affecting AM/PM of some observations #3437

tiwane opened this issue May 3, 2022 · 1 comment · Fixed by #3450
Assignees
Labels

Comments

@tiwane
Copy link
Contributor

tiwane commented May 3, 2022

From https://forum.inaturalist.org/t/incorrectly-shown-time/31450

  1. With your account's locale set to English, upload this photo via the web and give a location of 55.901087, 37.849474 (in the Moscow area).
  2. The observation should show the correct observed on time, according to the photo's metadata.

image

3. Its JSON shows an observed_on_time of `2022/05/01 11:04 PM` 4. Change your account's locale to Russian. 5. Upload the same photo and give it the same location. 6. Observation shows AM (both in Russian and English, here's the English screenshot)

image

7. Its JSON shows an observed_on_string of `2022/05/01 11:04 вечера`

Weirdly, though, if you upload this photo and use 55.902732, 37.848835 for its location it works fine in both English and Russian account locale settings.

Users's original observations with these photos are at https://www.inaturalist.org/observations/114453949 and https://www.inaturalist.org/observations/114288623.

@tiwane tiwane added the bugs label May 3, 2022
@tiwane tiwane changed the title User's locale affecting AM/PM display of observation. User's locale affecting AM/PM of some observations May 3, 2022
@kueda
Copy link
Member

kueda commented May 3, 2022

Some questions

  1. When you say "The observation should show the correct observed on time" do you mean on the obs detail page, e.g. https://www.inaturalist.org/observations/115012325?
  2. When you say, "its JSON" do you mean https://www.inaturalist.org/observations/115012325.json, https://api.inaturalist.org/v1/observations/115012325, or something else?
  3. There is no JSON attribute called observed_on_time that I can see, but maybe I'm not using the right parameters. What URL are you looking at when you see that?

@kueda kueda self-assigned this May 19, 2022
kueda added a commit that referenced this issue May 19, 2022
Also attempts to replace AM / PM translated into other languages with the
literal English values when parsing a date with Chronic.
kueda added a commit that referenced this issue May 20, 2022
* Use parsable date format for EXIF date in Uploader (#3437)

Also attempts to replace AM / PM translated into other languages with the
literal English values when parsing a date with Chronic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants