Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DwC-A should not have data files without meta.xml entries #3862

Closed
kueda opened this issue Sep 7, 2023 · 1 comment
Closed

DwC-A should not have data files without meta.xml entries #3862

kueda opened this issue Sep 7, 2023 · 1 comment

Comments

@kueda
Copy link
Member

kueda commented Sep 7, 2023

Per globalbioticinteractions/globalbioticinteractions#427 (comment), when we use the make_api_all_taxon_data method, we just write a taxa.csv file into the archive without describing what it is and what its fields are in meta.xml. Instead, I think we should treat it like an extension to the observation core so it gets described in meta.xml.

There's also a lot of refactoring we could do in archive.rb, e.g. make_descriptor and make_descriptor both seem to contain a lot of logic that could be moved into the extension classes, but maybe that's out of scope.

@pleary
Copy link
Member

pleary commented Nov 7, 2023

I just focused on the ticket title and not the refactoring. I removed the make_api_all_taxon_data method and associated archive option since we aren't using it anymore. I'm not aware of other files that will get created that aren't documented in meta.xml

@pleary pleary closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants