You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Per globalbioticinteractions/globalbioticinteractions#427 (comment), when we use the make_api_all_taxon_data method, we just write a taxa.csv file into the archive without describing what it is and what its fields are in meta.xml. Instead, I think we should treat it like an extension to the observation core so it gets described in meta.xml.
There's also a lot of refactoring we could do in archive.rb, e.g. make_descriptor and make_descriptor both seem to contain a lot of logic that could be moved into the extension classes, but maybe that's out of scope.
The text was updated successfully, but these errors were encountered:
I just focused on the ticket title and not the refactoring. I removed the make_api_all_taxon_data method and associated archive option since we aren't using it anymore. I'm not aware of other files that will get created that aren't documented in meta.xml
Per globalbioticinteractions/globalbioticinteractions#427 (comment), when we use the
make_api_all_taxon_data
method, we just write ataxa.csv
file into the archive without describing what it is and what its fields are inmeta.xml
. Instead, I think we should treat it like an extension to the observation core so it gets described inmeta.xml
.There's also a lot of refactoring we could do in
archive.rb
, e.g.make_descriptor
andmake_descriptor
both seem to contain a lot of logic that could be moved into the extension classes, but maybe that's out of scope.The text was updated successfully, but these errors were encountered: