Coordinate obscuration by day #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt, w/ opt-in for user geoprivacy (#2037)
…ance of user spec.
…user geoprivacy obscured for folks not in the test.
pleary
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
I'm not seeing any red flags here. I tried out a few of the new methods and delayed jobs which worked well, and attempted to do things like obscure things twice which was appropriately prevented. I added preload user preferences to bulk obs indexing as those were being queried for within the index loop (I also added preloading for ID taxa for the already committed ident_taxon_ids). Look good to merge to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2037. Obscures all obs by a user made on the same day as they observed a threatened taxon. Currently an opt-in test only available to staff.