Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate photos between buckets based on license #3789

Merged
merged 3 commits into from Jun 28, 2023
Merged

Migrate photos between buckets based on license #3789

merged 3 commits into from Jun 28, 2023

Conversation

sylvain-morin
Copy link
Contributor

No description provided.

Copy link
Member

@pleary pleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. Adding the dot after the where and updating the unique_hash is probably the highest priority, then maybe replacing some hard-coded values to make it more readable. Then there are the smaller code-formatting changes (indent each line with two spaces, spaces before/after parens and operators).

This scripts will likely take a while to run, and I often find it helpful to output debugging statements along the way so I can monitor how far along it is in the process. I'd probably include something like "Starting batch #{index}" just inside the while loop so I'd have an idea of how far along it is and how much longer it might take to finish

tools/migrate_photo_from_odp.rb Outdated Show resolved Hide resolved
tools/migrate_photo_to_odp.rb Outdated Show resolved Hide resolved
tools/migrate_photo_from_odp.rb Outdated Show resolved Hide resolved
tools/migrate_photo_to_odp.rb Outdated Show resolved Hide resolved
tools/migrate_photo_from_odp.rb Outdated Show resolved Hide resolved
tools/migrate_photo_to_odp.rb Outdated Show resolved Hide resolved
tools/migrate_photo_from_odp.rb Outdated Show resolved Hide resolved
tools/migrate_photo_from_odp.rb Outdated Show resolved Hide resolved
@pleary pleary merged commit 0996f27 into main Jun 28, 2023
32 checks passed
@pleary pleary deleted the s3-audit branch June 28, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants