Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial nits and suggestions #198

Merged
merged 2 commits into from Oct 25, 2020
Merged

Editorial nits and suggestions #198

merged 2 commits into from Oct 25, 2020

Conversation

tfpauly
Copy link
Contributor

@tfpauly tfpauly commented Oct 12, 2020

No description provided.

@shwethab
Copy link
Collaborator

Thanks for the detailed review and changes. This looks good to me.

brockners
brockners reviewed Oct 18, 2020
View reviewed changes
Copy link
Collaborator

@brockners brockners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tommy, thanks a lot for the detailed review and the suggested updates.
There are two small nits I found while reading through the updated version.
Could you update the PR accordingly? Many thanks!

drafts/draft-ietf-ippm-ioam-ipv6-options.xml Outdated Show resolved Hide resolved
drafts/draft-ietf-ippm-ioam-ipv6-options.xml Outdated Show resolved Hide resolved
@brockners brockners merged commit c6883f8 into inband-oam:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brockners brockners brockners left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tfpauly @shwethab @brockners