Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiconfig #13

Closed
wants to merge 111 commits into from
Closed

Multiconfig #13

wants to merge 111 commits into from

Conversation

packadal
Copy link

This fixes tests 184 through 191.

The problem was that a default CMAKE_BUILD_TYPE was added, and MinSizeRel and RelWithDebInfo were not in the default list.

…ile. initially configure the correct build command
…he compiler flags extracted... albeit assuming C language. Next to get the linker options extracted too
…ds properly in future. Works a bit less than before
…pecific targets aren't coming through properly
…psulate all projects.. so structure may need to change again
inbilla and others added 26 commits July 14, 2015 23:16
Missed moving one part out of a WIN32 section
This is for use with generator expressions that include ConfigName. A better solution needs to be found.
This appears consistent with Ninja generator behaviour and hopefully solves some gcc issues for use in linux
Distributable compile should be possible with this change (currently untested)
This solves issues linking to libraries that are on paths with spaces in them.
I needed to put Quotes around these placeholders, but the quotes would not stay when extracting the command from the front of the string. (They would be removed by the argument parsing code).
So instead I've used a placeholder with no quotes, and the quotes are preserved inside the placeholder's value.
The argument parsing code most likely needs to be removed from the equation entirely and custom code for extracting the executable at the front of the string written instead.
Once that is done, this code could be reverted back to the more sane version.
* properly escape single quotes in strings
* re-ordered variables and pre-build  dependencies
…ame name as a source file

e.g. test.cxx and test.rc were both compiled to test.obj.
now test.rc is compiled to test.res
This is necessary as fastbuild uses windows' CreateProcess, which does not support output redirections with '>'.
This may work on linux, but I cannot test it.

The test 'CustomCommand' finally passes

Removed an unused function and an unused functor struct
FastBuild Generator: some fixes for custom command execution
Fastbuild does not behave the same as the makefile generator with relative paths.
Exclude Fastbuild from the CMP0021 test
Check if parent makefiles are excluded from all
Source groups now break up files by directory so the output names don't collide
Also added MinSizeRel and RelWithDebInfo configurations.
Also make sure that no default configuration is passed in CMAKE_BUILD_TYPE.
@inbilla
Copy link
Owner

inbilla commented Nov 29, 2015

Thanks Packadal, I'll try get this in as soon as possible.
I've been a bit busy lately, but I haven't forgotten.
Thanks heaps!

@inbilla
Copy link
Owner

inbilla commented Mar 9, 2016

Merged manually - Closing
Thanks!

@inbilla inbilla closed this Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants