forked from Kitware/CMake
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiconfig #13
Closed
Closed
Multiconfig #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile. initially configure the correct build command
…per target generation and configuration
…he compiler flags extracted... albeit assuming C language. Next to get the linker options extracted too
…ds properly in future. Works a bit less than before
…first successfull fastbuild build
…pecific targets aren't coming through properly
…m to be in the correct places
…psulate all projects.. so structure may need to change again
…ppears hard to choose
Missed moving one part out of a WIN32 section
build warning fixes
This is for use with generator expressions that include ConfigName. A better solution needs to be found.
This appears consistent with Ninja generator behaviour and hopefully solves some gcc issues for use in linux
Distributable compile should be possible with this change (currently untested)
This solves issues linking to libraries that are on paths with spaces in them.
I needed to put Quotes around these placeholders, but the quotes would not stay when extracting the command from the front of the string. (They would be removed by the argument parsing code). So instead I've used a placeholder with no quotes, and the quotes are preserved inside the placeholder's value. The argument parsing code most likely needs to be removed from the equation entirely and custom code for extracting the executable at the front of the string written instead. Once that is done, this code could be reverted back to the more sane version.
* properly escape single quotes in strings * re-ordered variables and pre-build dependencies
…ame name as a source file e.g. test.cxx and test.rc were both compiled to test.obj. now test.rc is compiled to test.res
fixed RC generation
This is necessary as fastbuild uses windows' CreateProcess, which does not support output redirections with '>'. This may work on linux, but I cannot test it. The test 'CustomCommand' finally passes Removed an unused function and an unused functor struct
FastBuild Generator: some fixes for custom command execution
Fastbuild does not behave the same as the makefile generator with relative paths.
Exclude Fastbuild from the CMP0021 test
Check if parent makefiles are excluded from all
…tput path per ObjectList accordingly
Source groups now break up files by directory so the output names don't collide
Also added MinSizeRel and RelWithDebInfo configurations. Also make sure that no default configuration is passed in CMAKE_BUILD_TYPE.
packadal
force-pushed
the
multiconfig
branch
from
November 10, 2015 13:45
7235a4a
to
d335ec0
Compare
Thanks Packadal, I'll try get this in as soon as possible. |
Merged manually - Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes tests 184 through 191.
The problem was that a default CMAKE_BUILD_TYPE was added, and MinSizeRel and RelWithDebInfo were not in the default list.