Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1x1 UTM squares hard to distinguish #58

Closed
SanderDevisscher opened this issue Oct 6, 2023 · 9 comments
Closed

1x1 UTM squares hard to distinguish #58

SanderDevisscher opened this issue Oct 6, 2023 · 9 comments
Assignees
Labels
enhancement Improvement of existing code

Comments

@SanderDevisscher
Copy link
Collaborator

SanderDevisscher commented Oct 6, 2023

Is your feature request related to a problem? Please describe.
Currently the 1x1km squares on the species information observations map are green.
Especially when you activate the globe these are very hard to distinguish.

Describe the solution you'd like
I would like to see them in another color with contrasts enough from the background map. I would say red but this gives issues for our color impaired users. suggestions are welcome.

Current version (Lithobates catesbeianus):
image

@SanderDevisscher SanderDevisscher added the enhancement Improvement of existing code label Oct 6, 2023
@mvarewyck
Copy link
Collaborator

It's currently based on the order in the inbo_palette()

(1) I can exclude the first two (green and blue) colors for this plot, so it starts with 'orange'.

Screenshot from 2023-10-11 14-30-24

(2) I can exclude the first four colors, so it starts with dark purple

Screenshot from 2023-10-11 14-32-40

(3) I can hard-code red squares

Screenshot from 2023-10-11 14-36-00

@SanderDevisscher preference?

@SanderDevisscher
Copy link
Collaborator Author

@ThomasScheppers @Fhuysent can I borrow your colorblindness ? can you please give your preference ?

@Fhuysent
Copy link

Given the choice between those three, I prefer the red (option 3).
Purple is also OK, but not very nice I think. Orange is difficult to see for colorblinds.

@SanderDevisscher
Copy link
Collaborator Author

personally I would go for red also

@mvarewyck
Copy link
Collaborator

Is it fine to add red as the first color for the other plots too relying on this piece of code?

Screenshot from 2023-10-11 16-49-57

@SanderDevisscher
Copy link
Collaborator Author

@Fhuysent what do you think ?

@Fhuysent
Copy link

Yes, looks great! Red and green can be somewhat tricky to use next to each other, but these are different enough for even colorblinds.

@SanderDevisscher
Copy link
Collaborator Author

@mvarewyck go ahead

@mvarewyck
Copy link
Collaborator

@Fhuysent Is the blue color also a good option?
See here: #50 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing code
Projects
None yet
Development

No branches or pull requests

3 participants