Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute colour scale #183

Open
4 tasks
peterdesmet opened this issue Mar 27, 2023 · 1 comment
Open
4 tasks

Use absolute colour scale #183

peterdesmet opened this issue Mar 27, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@peterdesmet
Copy link
Member

The vp-color-scale is currently relative, i.e. the maximum colour is assigned to the maximum number in the current data range. This makes it hard to interpret the data:

Screenshot 2023-03-27 at 10 49 30

Screenshot 2023-03-27 at 10 49 19

  • How is bioRad doing this? @adokter
  • Is it technically possible to implement a maximum in CROW? @niconoe @stijnvanhoey
  • Is it possible to define an absolute maximum across all radars? @adokter @CeciliaNilsson709
  • Or should we assign a maximum per radar (e.g. in the settings), which might make it harder again to compare radars?
@peterdesmet peterdesmet added the enhancement New feature or request label Mar 27, 2023
@niconoe
Copy link
Collaborator

niconoe commented Mar 29, 2023

I don't think there is any technical issue in making the max of the scale fixed. My reasoning at the time was probably that it was hard to decided what the max should be (wide variation across days and radars), so making it dynamic avoided the issue. As you mention, it has a cost: the comparisons are difficult.

In practice, making it fixed will probably allow to simplify the code a bit. We'll have to make sure the D3 scales have the "clamping" feature on, so the values above the max are clamped to it (rather than triggering an error).

@peterdesmet peterdesmet added this to the Aloft milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants