-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict in functions due to new column called "project_type" in view/database #59
Comments
PR #60 fixes the issue in the R code, however the unit test check when changing views in the database would be a valid part of the workflow. Moreover, the projects view now has a column |
@stijnvanhoey After discussion with @bwydoogh, we decided to rename the column |
Done. |
@damianooldoni also, here; should we add this as a unit-test (maybe with ref to the issue and some context description about the naming, as a kind of 'minimal' documentation? As far as I know, there is no real/specific documentation about the provided dbase views... |
@stijnvanhoey : yes, I agree. I don't think a unit-test is the best place where to get context description or minimal documentation. A reference to the issue in unit-test seems good. This change in column name could be otherwise added in general documentation/vignette. And maybe in description of the (related) functions as well? |
Does we need to do anything here? Or can this issue be closed? |
@jreubens I guess so. Issue is assigned to you and myself (and I renamed the field, so "job done"). |
While starting solving issue #24 I found that many functionalities of package
etn
start crashing or not returning the desired result. After debugging @stijnvanhoey and I are both very sure that the problem is the introduction of a new column calledproject_type
. Using such a name is quite unlucky because it is also the name of input parameter for filtering onanimal
ornetwork
projects. Anddplyr
doesn't like this at all unfortunately 😢I see two options:
In order to prevent this kind of bugs in the future, could @bwydoogh, @jreubens, the unit-tests perform in RStudio before any update of views/database?
It is just one line of code:
If no errors are returned, then the change is welcome!
The text was updated successfully, but these errors were encountered: