-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude "sync tag" when returning detections #24
Comments
Yes, the |
Ok, so for any relevant function, it would be useful something like a |
Indeed and name is good for me. |
Ok to have an function to exclude non-animals. |
I'd opt for parameter, not separate functions. Maybe called |
Reference tags are a good, general name for non-animal tags. Function name proposed by Peter is ok for me. |
For which functions is this relevant?
@PieterjanVerhelst and @jreubens can you verify this? |
I think it is only relevant for the |
Regarding issue #50 and the discussion above. Let's summarize the required implementation: The aim is an additional argument
Still, I do not completely get how to exclude these? On what field name doe we have to filter or how can I extend the query? Moreover, we need a complete and proper list of values to identify non-animals. What is the field to use for |
Referring to #50 you should use the field 'Acoustic_tag_type' to filter on. only the type "animal" is animal, all the other (built-in, sentinel, sync) are non-animal. |
@jreubens I can see the How can I exclude them when requesting animals? Should I use the field To conclude, this also make sense for the |
I'm not sure whether I understand your question correctly. for get_transmitters() use the 'acoustic_tag_type' and exclude everything that is not 'animal' |
@jreubens for the This issue is particularly about the |
Hi! Yes, @stijnvanhoey, I will. |
After reading the entire issue, I will proceed by introducing a new input parameter for function get_transmitters(con) #no reference tags included
get_transmitters(con, include_reference_tags = FALSE) #no reference tags included
get_transmitters(con, include_reference_tags = TRUE) #reference tags included I will deploy it in a new branch called |
See list in #21. I would propose to exclude "sync tag" by default when returning occurrences, but maybe allow a flag to include those. @jreubens @PieterjanVerhelst are there other non animal detections in the database?
The text was updated successfully, but these errors were encountered: