Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude "sync tag" when returning detections #24

Closed
peterdesmet opened this issue Apr 27, 2018 · 16 comments
Closed

Exclude "sync tag" when returning detections #24

peterdesmet opened this issue Apr 27, 2018 · 16 comments

Comments

@peterdesmet
Copy link
Member

See list in #21. I would propose to exclude "sync tag" by default when returning occurrences, but maybe allow a flag to include those. @jreubens @PieterjanVerhelst are there other non animal detections in the database?

@PieterjanVerhelst
Copy link
Collaborator

Yes, the Built-in and Sentinel are non-animals as well.

@peterdesmet
Copy link
Member Author

Ok, so for any relevant function, it would be useful something like a exclude_non_animals parameter, with default value TRUE. Better name suggestions welcome.

@PieterjanVerhelst
Copy link
Collaborator

Indeed and name is good for me.

@jreubens
Copy link
Collaborator

Ok to have an function to exclude non-animals.
as name I would go for 'reference_tags'
@PieterjanVerhelst OK?

@peterdesmet
Copy link
Member Author

I'd opt for parameter, not separate functions. Maybe called include_reference_tags, default FALSE

@stijnvanhoey stijnvanhoey added this to the package release 0.1.0 milestone Apr 30, 2018
@PieterjanVerhelst
Copy link
Collaborator

Reference tags are a good, general name for non-animal tags. Function name proposed by Peter is ok for me.

@stijnvanhoey
Copy link
Contributor

stijnvanhoey commented May 2, 2018

For which functions is this relevant?

  • get_projects() | Get project overview
  • get_receivers() | Get receiver data
  • get_deployments() | Get deployments data
  • get_animals() | Get animals data
  • get_transmitters() | Get transmitter metadata

@PieterjanVerhelst and @jreubens can you verify this?

@PieterjanVerhelst
Copy link
Collaborator

I think it is only relevant for the get_transmitters() function. Deployments reflect receiver activity and therefore not relevant for that function.

@jreubens
Copy link
Collaborator

get_animals as well.
BUT... we will link 'scientific_name' to aphia of worms soon. Thus this means that built-in, sentinel, ... can't be seen as 'animals' any longer. an new field will be needed. @bwydoogh en @jreubens wil work on this

@stijnvanhoey
Copy link
Contributor

Regarding issue #50 and the discussion above. Let's summarize the required implementation:

The aim is an additional argument include_reference_tags (default FALSE), so for example the implementation would be:

get_transmitters(con) #no reference tags included
get_transmitters(con, include_reference_tags = FALSE) #no reference tags included
get_transmitters(con, include_reference_tags = TRUE) #reference tags included

Still, I do not completely get how to exclude these? On what field name doe we have to filter or how can I extend the query? Moreover, we need a complete and proper list of values to identify non-animals.

What is the field to use for get_transmitters()?
What is the field to use for get_animals()?
What terms need to be excluded: built-in, Sentinel and Sync-tag? Or others as well?

@jreubens
Copy link
Collaborator

Referring to #50 you should use the field 'Acoustic_tag_type' to filter on. only the type "animal" is animal, all the other (built-in, sentinel, sync) are non-animal.

@stijnvanhoey
Copy link
Contributor

stijnvanhoey commented May 29, 2018

@jreubens I can see the acoustic_tag_type when requesting the transmitter information (get_transmitters), but I do not get it for the animals.

How can I exclude them when requesting animals? Should I use the field scientific_name (and how to make the difference there)? As an animal can be linked to different tags, how should I be able to exclude based on the acoustic_tag_type, which is linked to tags... so, If any of the tags is an animal, it is an animal?!?

To conclude, this also make sense for the get_detections... Should I also use the scientific_name and exclude certain names?

@jreubens
Copy link
Collaborator

I'm not sure whether I understand your question correctly.

for get_transmitters() use the 'acoustic_tag_type' and exclude everything that is not 'animal'
for get_animals() the problem will be solved once we use the aphia_ID. Thus I would wait with this one.

@stijnvanhoey
Copy link
Contributor

@jreubens for the get_animalsyou can add a separate issue now of later on when the ID is available.

This issue is particularly about the get_transmitters() and using the acoustic_tag_type and exclude as such everything that is not 'animal'... @damianooldoni any fit to take this in your schedule?

@damianooldoni
Copy link
Member

Hi! Yes, @stijnvanhoey, I will.

@damianooldoni
Copy link
Member

After reading the entire issue, I will proceed by introducing a new input parameter for function get_transmitter() called include_reference_tags which acts as a filter. I will follow the instructions as written by @stijnvanhoey above, i.e.

get_transmitters(con) #no reference tags included
get_transmitters(con, include_reference_tags = FALSE) #no reference tags included
get_transmitters(con, include_reference_tags = TRUE) #reference tags included

I will deploy it in a new branch called include_reference_tags_param.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants