Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vignette suggestions #36

Merged
merged 6 commits into from
Sep 2, 2022
Merged

vignette suggestions #36

merged 6 commits into from
Sep 2, 2022

Conversation

sarahcd
Copy link
Collaborator

@sarahcd sarahcd commented Sep 1, 2022

Minor suggestions for the vignette. One additional request is for the messages shown as the code is executed. Where messages say 'Please make sure you have the right to access data....', please somewhere refer to 'Movebank’s terms of use at https://www.movebank.org/cms/movebank-content/general-movebank-terms-of-use'. If you point me to the file/s with the message text I can suggest it there directly.

@peterdesmet
Copy link
Member

Sarah, I made a minor correction (1da44e0) and added you as contributor (43738e6) 🎉 . Can you verify the info is correct?

@sarahcd
Copy link
Collaborator Author

sarahcd commented Sep 2, 2022

all correct!

@peterdesmet peterdesmet merged commit c35c4bc into vignette_review Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants