Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@inbucket is displayed instead of actual domain #31

Closed
tommywo opened this issue Mar 17, 2016 · 4 comments
Closed

@inbucket is displayed instead of actual domain #31

tommywo opened this issue Mar 17, 2016 · 4 comments
Assignees
Milestone

Comments

@tommywo
Copy link
Contributor

tommywo commented Mar 17, 2016

Hi! Nice app!

@jhillyerd
Copy link
Collaborator

Thanks! The @inbucket (next the View button is what I'm assuming you are referring to) is intentional. Inbucket actually accepts mail for any domain, so I didn't want people to think they had to send mail to just the configured smtp greeting domain.

The idea is that if you were testing your application with production data, inbucket would happily accept mail for an @gmail.com user or a @hotmail.com user.

Perhaps I should edit the default homepage (greeting.html) to make all this more clear.

Edit: I could also make the @inbucket configurable, for setups that might only accept a single domain due to their internal mail routing.

@tommywo
Copy link
Contributor Author

tommywo commented Mar 17, 2016

Ok I get it :), but the ui suggest that is for one domain only

So i think it would be better to identify mailbox by complete email, and get rid of '@inbucket' by the 'View' button.

@jhillyerd
Copy link
Collaborator

Definitely gonna need more docs on it. :) Inbucket completely ignores the domain - james@gmail.com and james@inbucket.com are both "james" as far Inbucket is concerned, and the mail goes into the same mailbox.

The reason I added the @inbucket UI element was people were confused what to type into the box at all, they thought it was a search feature.

Edit: Nevermind, I see you already understand how it works and are suggesting a change. I'll think on it, but Inbucket is already use by a number of people and testing tools at my company so I probably wouldn't be doing anything that drastic.

@tommywo
Copy link
Contributor Author

tommywo commented Mar 23, 2016

@jhillyerd we went a little off topic, making this '@inbucket' element configurable would be great. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants