Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

Replace ineffective String concat in dialect.scala #79

Open
timowest opened this issue Nov 4, 2011 · 2 comments
Open

Replace ineffective String concat in dialect.scala #79

timowest opened this issue Nov 4, 2011 · 2 comments

Comments

@timowest
Copy link

timowest commented Nov 4, 2011

dialect.scala features non-optimal String concatenation in

def select(q: Select[_]): String = { ...

Consider using StringBuilder for it.

@inca inca closed this as completed Nov 6, 2011
@inca inca reopened this Nov 6, 2011
@inca
Copy link
Owner

inca commented Nov 6, 2011

Yes, you are right. Actually, I am thinking of some kind of QueryFormatter helper, which holds a mutable StringBuilder instance inside and also capable of pretty-formatting queries. Hope I'll get my hands on this one someday :)

@timowest
Copy link
Author

timowest commented Nov 6, 2011

Sounds like a good idea. Providing both single and multi-line serialization would be nice, I am not sure, if it's already there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants