Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :x-axis, :y-axis to all charts #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

holyjak
Copy link
Contributor

@holyjak holyjak commented Jan 13, 2014

I'd like to discuss how to add options for x, y axes to all charts [where it makes sense].

I have a few challenges I'd appreciate an advice on:

  1. Where does it make sense to do this for all applicable chart? So far I have blindly added a call to set-axes to wherver call to set-theme was
  2. How to test that it works? Do we f.ex. have a file that creates all the possible charts and has, for each one, display what they should look like? I feel that it would be quitedifficult for me to 1) find out how to create all the charts (yeah, go through docs, copy the simplest example, ...); 2) check that they look reasonably (perhaps w/o and w/ a custom axis / axes?)
  3. TODO: All docstrings must be updated to mention the :(x|y)-axis keys
  4. It likely does not work for all charts;they either must have range + domain axes or
    1. be a PolarPlot - which hasn't x, y axis but just one axis, so perhaps the default keys :(x|y)-axis are confusing? how to handle these special cases nicely?
    2. be a ThermometerPlot - only one axis as on PolarPlot, called range axis
    3. => what to do for the other charts?

I'd also appreciate recommendations regarding improvements of the code.

@eigenhombre
Copy link

+1 on the gallery of example charts. I do this, for example, on i3d3[1]. Like unit tests, the collection doesn't have to be exhaustive to be useful. One can add new examples as problems are encountered and fixed.

[1] https://github.com/eigenhombre/i3d3

@holyjak
Copy link
Contributor Author

holyjak commented Oct 30, 2018

If I fix the conflicts, will this be merged or would that be a wasted effort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants